Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36867 )
Change subject: cbfs: Make cbfs_default_props() hidden again ......................................................................
Patch Set 1:
Patch Set 1:
Another question for you: I looked at this for a few mins earlier. We're currently utilizing offset/size properties. Should we make this API fill out a region device?
How about just replacing struct cbfs_props with struct region everywhere? They're the exact same struct on the inside, I don't understand why they have different names anyway. Then your apollolake problem should go away because you can call region_is_subregion() directly on the thing cbfs_default_props() fills out.
Ya. I thought about that as well earlier. I forgot why I separated the types to begin with. I can't remember. I can try and do that next.