Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34337 )
Change subject: soc/intel/common: add PAD_CFG_NF_BUF_TRIG macro
......................................................................
Patch Set 4:
Patch Set 3:
I personally find the GPIO macros very cryptic, and would prefer something more like sandybridge and ivybridge's gpio.c if possible.
Did you mean to use separate structures instead of macros? As it is done in https://github.com/coreboot/coreboot/blob/master/src/mainboard/asrock/b75pro...
Honestly, macros look better to me ) But that's my personal opinion
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9fe50ff9a680633db6228564345200c0e1ee3ea
Gerrit-Change-Number: 34337
Gerrit-PatchSet: 4
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Jul 2019 13:41:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment