Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42696 )
Change subject: nb/intel/ironlake/northbridge.c: Drop thunk functions
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42696/1/src/northbridge/intel/ironl...
File src/northbridge/intel/ironlake/northbridge.c:
https://review.coreboot.org/c/coreboot/+/42696/1/src/northbridge/intel/ironl...
PS1, Line 223: northbridge_init
is this still right?
Yes, I renamed "northbridge_dmi_init" to "northbridge_init". Should I preserve the old name instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42696
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c997a63cbbd2b1029f94c23685847df910f8a0e
Gerrit-Change-Number: 42696
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Jul 2020 19:24:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment