Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86087?usp=email )
Change subject: ec/starlabs/merlin/acpi: Move Q Events under EC device ......................................................................
ec/starlabs/merlin/acpi: Move Q Events under EC device
For the Q events to be used, they need to sit under the EC device in ACPI. Move them accordingly.
Change-Id: I58a41ae660ec466a08d4c290ff820b713b866f4f Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86087 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/ec/starlabs/merlin/acpi/hid.asl 1 file changed, 9 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/ec/starlabs/merlin/acpi/hid.asl b/src/ec/starlabs/merlin/acpi/hid.asl index 4a85f04..f3bfff6 100644 --- a/src/ec/starlabs/merlin/acpi/hid.asl +++ b/src/ec/starlabs/merlin/acpi/hid.asl @@ -1,14 +1,17 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#if CONFIG(EC_STARLABS_MERLIN) -Method (_Q05, 0, NotSerialized) // Event: Backlight Brightness Down +Scope (_SB.PCI0.LPCB.EC) { - ^HIDD.HPEM (20) -} + Method (_Q05, 0, NotSerialized) // Event: Backlight Brightness Down + { + ^^^^HIDD.HPEM (20) + }
-Method (_Q06, 0, NotSerialized) // Event: Backlight Brightness Up -{ - ^HIDD.HPEM (19) + Method (_Q06, 0, NotSerialized) // Event: Backlight Brightness Up + { + ^^^^HIDD.HPEM (19) + } } #endif