Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42906 )
Change subject: mb/google/dedede: set tcc_offset value to 10
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42906/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42906/2//COMMIT_MSG@10
PS2, Line 10: Circuit (TCC) activation feature.
What is the default value?
Default value is 0 and here setting the same value as initial value. Going forward we need to fine tune this value and update devicetree entry.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53d1bd413c64643cf8bdaef266bde25a2f3a97ee
Gerrit-Change-Number: 42906
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Jul 2020 16:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment