Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39534 )
Change subject: nb/intel/i945/raminit: Simplify if condition
......................................................................
Patch Set 2:
Patch Set 2:
This is true if we have only 2 DIMMs. in other words we MUST have at least one DIMM populated.
if we have 4 DIMMs (at SPD 0x50, 0x51, 0x52 and 0x53), the old and new one are wrong.
Up to you if you want to merge equivalent wrong code.
Yes, I know i945 raminit is doing weird things for desktop stuff, but the scope of this change is to not change the behavior of the code. If that makes a mistake much more obvious, great! Another patch can fix it 😄
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39534
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I041f2740d6991f9b4e6b8f77988b970c028ca512
Gerrit-Change-Number: 39534
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Mar 2020 10:51:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment