Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46259 )
Change subject: intel/common/pmc: Add functions for IPC mailbox in ACPI ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46259/11/src/soc/intel/common/block... File src/soc/intel/common/block/pmc/pmc_ipc.c:
https://review.coreboot.org/c/coreboot/+/46259/11/src/soc/intel/common/block... PS11, Line 127: /* Package with return value and read buffer. */ : acpigen_write_name("RVAL"); : acpigen_write_package(5); : for (i = 0; i < 5; ++i) : acpigen_write_integer(0); : acpigen_pop_len(); : suggestion: IASL always suggests not creating named objects inside of a method (i'm guessing it's a performance issue); I usually keep them in the same scope as the method if I can