Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31035 )
Change subject: google/kukui: Revise FMAP layout for larger CBFS
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31035/4/src/mainboard/google/kukui/chromeos....
File src/mainboard/google/kukui/chromeos.fmd:
https://review.coreboot.org/#/c/31035/4/src/mainboard/google/kukui/chromeos....
PS4, Line 6: 0x1e4000
BTW, you can leave values out that can be inferred (like the size here) if you just want it to fill […]
Thanks, but I'd prefer to keep current form, which helps us to make sure all addressed were properly aligned, and also easier to debug if we have to code the address to somewhere in config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22cff99dca8c396c5897c3f6631721af40f3ffbd
Gerrit-Change-Number: 31035
Gerrit-PatchSet: 4
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ting Shen
phoenixshen@google.com
Gerrit-CC: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Comment-Date: Wed, 23 Jan 2019 01:49:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment