[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Revise FMAP layout for larger CBFS

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31035 )

Change subject: google/kukui: Revise FMAP layout for larger CBFS
......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/31035/4/src/mainboard/google/kukui/chromeos.... 
File src/mainboard/google/kukui/chromeos.fmd:

https://review.coreboot.org/#/c/31035/4/src/mainboard/google/kukui/chromeos.... 
PS4, Line 6: 0x1e4000
BTW, you can leave values out that can be inferred (like the size here) if you just want it to fill all available space. In fact, you could write this whole section as just:

WP_RO 2M {
   RO_SECTION {
     BOOTBLOCK 32K
     FMAP 4K
     COREBOOT(CBFS)
     GBB 0x2f00
     RO_FRID 0x100
   }
   RO_VPD 64K
 }

It's a bit of a matter of taste whether you find that harder or easier to read, but it does make it easier to play around with the sizes (and harder to accidentally leave some empty space somewhere).