Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36543 )
Change subject: security/vboot: Removed vboot_prepare from vboot_locator
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36543/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36543/3//COMMIT_MSG@11
PS3, Line 11: called too early.
You nailed it. The issue is in the stage where vboot becomes active. […]
Changed the solution according to Aaron's suggestion. This has been tested on the facebook fbg1701 system.
The thing we overlooked was the fact that romstage is loading POSTCAR instead of RAMSTAGE (on x86 that is).
So now the vboot will be initialized when either ROMSTAGE, POSTCAR or RAMSTAGE will be loaded. Of course depending on the VBOOT_STARTS_IN* setting. I assume the cases included in the commit are covering all possible situations.
The vboot_prepare has been renamed to vboot_run_logic() this has been done to highlight the change from a static function to one that is called from various places.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36543
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5e8fd78458c09dd3896bfd142bd49c2c3d686df
Gerrit-Change-Number: 36543
Gerrit-PatchSet: 4
Gerrit-Owner: Wim Vervoorn
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Wim Vervoorn
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Nov 2019 14:05:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Wim Vervoorn
Gerrit-MessageType: comment