Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39087 )
Change subject: util/lint: Permit capitalized coreboot at start of sentence
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
I don't think this is a good idea.
https://review.coreboot.org/c/coreboot/+/39087/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39087/1//COMMIT_MSG@10
PS1, Line 10: it seems proper
To whom?
https://review.coreboot.org/c/coreboot/+/39087/1//COMMIT_MSG@11
PS1, Line 11: proper text
What is "proper text"? Conversely, what would "improper text" be?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39087
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I344e52262956ba45c3abcd1e878284ba338353f1
Gerrit-Change-Number: 39087
Gerrit-PatchSet: 1
Gerrit-Owner: Ivan Labáth
iger@labo.rs
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Ivan Labáth
iger@labo.rs
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 24 Feb 2020 15:14:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment