Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35633 )
Change subject: mb/google/drallion: Set UART for console to UART controller 0
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35633/5/src/mainboard/google/dralli...
File src/mainboard/google/drallion/Kconfig:
https://review.coreboot.org/c/coreboot/+/35633/5/src/mainboard/google/dralli...
PS5, Line 94: default 0
Could we add the following change to avoid affecting arcada_cml and sarien_cml builds?
config UART_FOR_CONSOLE
int
- default 0
+ default 2 if BOARD_GOOGLE_ARCADA_CML
+ default 2 if BOARD_GOOGLE_SARIEN_CML
+ default 0 if BOARD_GOOGLE_DRALLION
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35633
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ae2f8459b6225b99b758180413afa22386355d4
Gerrit-Change-Number: 35633
Gerrit-PatchSet: 5
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Thu, 03 Oct 2019 23:10:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment