build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34793 )
Change subject: [WIP]drivers/aspeed: Add AST2500 support ......................................................................
Patch Set 1:
(27 comments)
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_tables.h:
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 53: #define VCLK25_175 0x00 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 54: #define VCLK28_322 0x01 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 55: #define VCLK31_5 0x02 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 56: #define VCLK36 0x03 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 57: #define VCLK40 0x04 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 58: #define VCLK49_5 0x05 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 59: #define VCLK50 0x06 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 60: #define VCLK56_25 0x07 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 61: #define VCLK65 0x08 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 62: #define VCLK75 0x09 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 63: #define VCLK78_75 0x0A please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 64: #define VCLK94_5 0x0B please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 65: #define VCLK108 0x0C please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 66: #define VCLK135 0x0D please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 67: #define VCLK157_5 0x0E please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 68: #define VCLK162 0x0F please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 69: /* #define VCLK193_25 0x10 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 70: #define VCLK154 0x10 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 71: #define VCLK83_5 0x11 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 72: #define VCLK106_5 0x12 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 73: #define VCLK146_25 0x13 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 74: #define VCLK148_5 0x14 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 75: #define VCLK71 0x15 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 76: #define VCLK88_75 0x16 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 77: #define VCLK119 0x17 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 78: #define VCLK85_5 0x18 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34793/1/src/drivers/aspeed/common/a... PS1, Line 79: #define VCLK97_75 0x19 please, no space before tabs