build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31105 )
Change subject: Revert "util/bincfg: code cleanup: convert sym_table to a local variable" ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/31105/1/util/bincfg/bincfg.h File util/bincfg/bincfg.h:
https://review.coreboot.org/#/c/31105/1/util/bincfg/bincfg.h@40 PS1, Line 40: static struct field *putsym (char const *, unsigned int); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/31105/1/util/bincfg/bincfg.h@41 PS1, Line 41: static struct field *getsym (char const *); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/31105/1/util/bincfg/bincfg.h@42 PS1, Line 42: static void yyerror (FILE* fp, char const *); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/31105/1/util/bincfg/bincfg.h@42 PS1, Line 42: static void yyerror (FILE* fp, char const *); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/31105/1/util/bincfg/bincfg.h@43 PS1, Line 43: int yylex (void); space prohibited between function name and open parenthesis '('