Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42193 )
Change subject: soc/mediatek/mt8183: Fix some programming errors of DRAMC setting ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG@7 PS2, Line 7: soc/mediatek/mt8183: Fix some programming errors of DRAMC setting I’d prefer a more specific commit message summary. Maybe split the commit up.
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG@9 PS2, Line 9: Fix some programming errors. Please elaborate.
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG@13 PS2, Line 13: TEST=Boots correctly on Kukui … as before, right?
Or did you see errors before?