Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33552 )
Change subject: mb/google/octopus: Override DDI1 DDC SDA/SCL for Garg HDMI
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/33552/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33552/2//COMMIT_MSG@8
PS2, Line 8:
Please add the motivation. […]
Done
https://review.coreboot.org/#/c/33552/2/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/garg/gpio.c:
https://review.coreboot.org/#/c/33552/2/src/mainboard/google/octopus/variant...
PS2, Line 29: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_127, NONE, DEEP, NF1, HIZCRx1,
Hi Furquan, Kane, for type-C DB, there is no external PU on DB so internal PU 20K might be needed bu […]
override GPIO by different SKU#, on SKU1 or SKU17 w/ DB or w/o DB, GPIO126 & GPIO127 will keep 3.3V (IPU 20K).
on SKU9, w/ DB, GPIO126 as DDC SDA keeps 3.3V (EPU 2.2K), GPIO127 as DDC SCL keeps 3.3V (EPU 2.2K), HDMI function test ok.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33552
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ad8e5aa52f503121b10fe353e4bf4021aee2061
Gerrit-Change-Number: 33552
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quantatw.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Jun 2019 10:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Kane Chen
kane.chen@intel.com
Comment-In-Reply-To: Kane Chen
kane.chen@intel.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Kevin Chiu
Kevin.Chiu@quantatw.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment