[coreboot-gerrit] Change in coreboot[master]: device/xhci: Add xHCI utility to enumerate capabilities

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41899 )

Change subject: device/xhci: Add xHCI utility to enumerate capabilities
......................................................................

Patch Set 5: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/41899/3/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/41899/3/src/device/Kconfig@814 
PS3, Line 814: config XHCI_UTILS
             : 	def_bool n
             : 	help
             : 	  Provides xHCI utility functions.
> I know it's fast to compile, but I don't want to slowly degrade compile time by adding unnecessary w […]

No, that's fine. It anyways is auto-selected by the XHCI driver, so mainboards don't really need to set this individually.

https://review.coreboot.org/c/coreboot/+/41899/5/src/device/xhci.c 
File src/device/xhci.c:

https://review.coreboot.org/c/coreboot/+/41899/5/src/device/xhci.c@54 
PS5, Line 54: (uint32_t *)
nit: This isn't really required.