[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add generic SMU service request

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41625 )

Change subject: soc/amd/picasso: Add generic SMU service request
......................................................................

Patch Set 2:

(4 comments)

still needs to be tested on real hardware

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c 
File src/soc/amd/picasso/smu.c:

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@2... 
PS1, Line 21: smu_poll_response
> Can you make this return the response value..

Done

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@2... 
PS1, Line 29: 		if (!smu_read32(REG_ADDR_MESG_RESP)) {
> this is very likely wrong; should probably be if (smu_read32(REG_ADDR_MESG_RESP))

Done

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@4... 
PS1, Line 47:
> The PPR says: […]

Not sure if that's really needed in practice, but I've added it

https://review.coreboot.org/c/coreboot/+/41625/1/src/soc/amd/picasso/smu.c@5... 
PS1, Line 56:
> Check the response value: […]

Done