Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42029 )
Change subject: smbios: Add option VPD_SMBIOS_VERSION that reads BIOS version from a VPD variable ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42029/8/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/42029/8/src/Kconfig@763 PS8, Line 763: default "firmware_version"
We don't have a strong requirement on making it configurable, and I am OK with either "version" or " […]
"firmware_version" sounds better, "version" is too unspecific.
I'm just trying to avoid making anything more complex than it'll likely ever need to be, so let's please just hardcode it for now. If anyone has a real need to use a different name later, we can still change it.
https://review.coreboot.org/c/coreboot/+/42029/13/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/42029/13/src/arch/x86/smbios.c@452 PS13, Line 452: t->bios_version = smbios_add_string(t->eos, get_bios_version()); Just move this line further up so you can combine all the conditional stuff in a single #if block?