Attention is currently required from: Mike Banon, Marshall Dawson, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38313 )
Change subject: AGESA,binaryPI boards: Drop invalid MP table files
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
also note CB:47081 […]
Should have been CB:47801
These two IRQ patches were offered to you to continue with in January 2020. You returned to the topic several months later and changed the approach from fixing the implementation to working around it, likely adding even more undesirable redundancy across the tables.
So you have a niche/obsolete feature and bugfixes for couple boards you have. When such bugfixes jeopardize the proper fix across those older AMD platforms, your chances to get your work merged are slim, I would say. In short; I don't plan to rebase my work on yours, and there is no indication of you willing to rebase your work on mine either. What do you want to do?
Nobody is saying MP tables could not be supported. That's why most of the were already reviewed for existing and obvious flaws. You're not telling with certainty that MP tables are even the ones you test for.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38313
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd13b8b006fce7383f3f73c3c0a5d51a71c0155b
Gerrit-Change-Number: 38313
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Comment-Date: Mon, 15 Mar 2021 16:18:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Mike Banon
mikebdp2@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment