Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34209 )
Change subject: pci_ids: Drop a block of unused, redundant definitions ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34209/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34209/1//COMMIT_MSG@9 PS1, Line 9: contained some : errors beside. :
whats that ?
At least one of the PCH IDs had MOBILE in the name, but isn't mobile at all. I didn't try to verify the others.
https://review.coreboot.org/c/coreboot/+/34209/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/34209/1/src/include/device/pci_ids.... PS1, Line 3198:
these IDs are not referred anywhere u mean ? like common block PCH code ? or report platform no wher […]
See Jenkins' score.