Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38212 )
Change subject: mb/google/hatch: Add noise mitigation setting for dratini/jinlon
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38212/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38212/3//COMMIT_MSG@9
PS3, Line 9: mitgation
The SW option is provided in intel doc 575216 and the same solution is applied on hatch board. […]
Ack
https://review.coreboot.org/c/coreboot/+/38212/3//COMMIT_MSG@14
PS3, Line 14: TEST=build and verify that noise reduce.
There is test report with HW/SW solution on issue tracker. […]
This is the recommended step by Intel. Any higher and the slew rates have much greater impact on the latencies mentioned elsewhere on this issue. Also doing some cap swapping on one of the rails to mitigate noise.
https://review.coreboot.org/c/coreboot/+/38212/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38212/4//COMMIT_MSG@9
PS4, Line 9: dived
divided?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38212
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65f47288a7b1da98296fdba87ab5ca0c3a567aaf
Gerrit-Change-Number: 38212
Gerrit-PatchSet: 5
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 06 Feb 2020 03:30:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Comment-In-Reply-To: Chen Wisley
wisley.chen@quantatw.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment