30 May
2019
30 May
'19
1:12 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33102 )
Change subject: ec/apple: ACPI code for Apple MacBooks ......................................................................
Patch Set 2:
(2 comments)
Can you use the new acpi syntax to make it more readable?
https://review.coreboot.org/#/c/33102/2/src/ec/apple/acpi/battery.asl File src/ec/apple/acpi/battery.asl:
https://review.coreboot.org/#/c/33102/2/src/ec/apple/acpi/battery.asl@3 PS2, Line 3: * missing copyright
https://review.coreboot.org/#/c/33102/2/src/ec/apple/acpi/battery.asl@17 PS2, Line 17: SPTR, 8, to many tabs
--
To view, visit https://review.coreboot.org/c/coreboot/+/33102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d4585aac8e3ebbfed6ce4d4e39fbc33ac983069
Gerrit-Change-Number: 33102
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev me@ch1p.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 30 May 2019 08:12:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment