31 Dec
2021
31 Dec
'21
12:38 a.m.
Attention is currently required from: Hung-Te Lin, Paul Menzel, Angel Pons, Jianjun Wang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56792 )
Change subject: soc/mediatek/mt8195: Add driver to configure PCIe ......................................................................
Patch Set 8:
(2 comments)
File src/soc/mediatek/mt8195/pcie.c:
https://review.coreboot.org/c/coreboot/+/56792/comment/eb543c69_2440ad53 PS3, Line 54: int i;
Done
The change is reverted in PS8.
File src/soc/mediatek/mt8195/pcie.c:
https://review.coreboot.org/c/coreboot/+/56792/comment/a340d930_274c6d54 PS8, Line 17: /* Some devices still need io ranges, remain 16MB for compatibility */ By "remain", do you mean "reserve"?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56792
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6799c53b03a33be91157ea088d829beb4272976
Gerrit-Change-Number: 56792
Gerrit-PatchSet: 8
Gerrit-Owner: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Fri, 31 Dec 2021 08:38:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-MessageType: comment