Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44751 )
Change subject: soc/amd/picasso: copy local info to transfer buf ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44751/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44751/1//COMMIT_MSG@8 PS1, Line 8:
Added more description. Let me know if there is still any unclear thing.
Thank you, I added some more notes.
https://review.coreboot.org/c/coreboot/+/44751/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44751/2//COMMIT_MSG@10 PS2, Line 10: 0c12abe Please prepend it with *commit*, and maybe use an eight or ten digit hash, so Gerrit marks it up as a link.
https://review.coreboot.org/c/coreboot/+/44751/2//COMMIT_MSG@13 PS2, Line 13: varaible variable
https://review.coreboot.org/c/coreboot/+/44751/2//COMMIT_MSG@13 PS2, Line 13: it as local varaible and didn't put data into the region. What problem did it cause?