Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30861 )
Change subject: mb/intel/coffeelake_rvp: Update mainboard UART Kconfig ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/30861/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30861/2//COMMIT_MSG@7 PS2, Line 7: soc/mainboard
It have only one board, that's better to be mb/intel/coffeelake_rvp
Done
https://review.coreboot.org/#/c/30861/2//COMMIT_MSG@9 PS2, Line 9: Update mainboard UART Kconfig for whlrvp
Add . at the end of sentence. Also better including a section about test.
Done
https://review.coreboot.org/#/c/30861/2/src/mainboard/intel/coffeelake_rvp/K... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/30861/2/src/mainboard/intel/coffeelake_rvp/K... PS2, Line 54: default 2
Will that need to be 0 for other variant?
Done