Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46867 )
Change subject: amdfwtool: Add an option to show debug message
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46867/2/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/46867/2/util/amdfwtool/amdfwtool.c@...
PS2, Line 604:
it would be good to print something like "PSP firmware components:" before printing the filenames to […]
Done
https://review.coreboot.org/c/coreboot/+/46867/2/util/amdfwtool/amdfwtool.c@...
PS2, Line 1481: == 1
I'd drop the == 1 in there
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e3bcc2c9e1b3edfed1ce845c1603b2a9a2bb044
Gerrit-Change-Number: 46867
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Nov 2020 07:01:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment