Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 64:
(63 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/198697f8_2a53dbfd PS64, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/689669f4_be0391dd PS64, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/1bd1a5ca_0da5d775 PS64, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/bfd994fb_a6558a21 PS64, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/966f9e1f_4558bec2 PS64, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/cf9f3f3a_ac93e0b2 PS64, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/eabd038d_519e13fe PS64, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/7b3c2367_a0db1bb5 PS64, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/0eb7b9e2_350b6503 PS64, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/4c31bd57_5824099d PS64, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/30325ca4_0ea8b64a PS64, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/1ed27a00_ad3bd518 PS64, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/f0f3e395_0bec066f PS64, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/a119ccda_98a80550 PS64, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwE820.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/dc34cfaf_54e5efe9 PS64, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwEc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/036ac8ea_b9457f0a PS64, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/1ff5f08d_cfcf85ee PS64, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIo.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/6a523a37_eb13c770 PS64, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/85f03367_0d5bbb57 PS64, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIoIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/7fd74aa5_8141ea5c PS64, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/1e7278ce_41ef0b2e PS64, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemory.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/16f0fd93_653c0551 PS64, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/59d464df_c5f8a62f PS64, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwMemoryIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/06d078bd_692d5d98 PS64, Line 34: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/44f4ed59_10963b38 PS64, Line 37: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/1f0d172e_ddcd045d PS64, Line 40: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/2d58b44c_bd2f59b1 PS64, Line 73: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns
File payloads/cbui/NuklearUI/NuklearRwNvram.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/e49c574d_e54d06d8 PS64, Line 37: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/7ce1ab0a_a03a1815 PS64, Line 40: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwPci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/b81200ae_da2a38c1 PS64, Line 89: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/11123d5a_562ef5ab PS64, Line 93: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwPciIndexData.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/4b068d4b_4d9c4be9 PS64, Line 156: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/1b879cd0_f650e310 PS64, Line 159: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwPciOptionRom.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/76821e18_d815dd68 PS64, Line 22: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/ed91a80d_a496812e PS64, Line 24: static const char *tabs[] = { "PnP Header", "Option ROM1", "Option ROM2" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/d4c7ed93_9dcd95f1 PS64, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/3c79a9eb_1d8c0cd0 PS64, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/17762e8f_0e087f7f PS64, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/70f249b3_ddf1e86e PS64, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/80ea7144_3560e556 PS64, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/686d9689_0070cd91 PS64, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/5c856ca7_de3d9ef5 PS64, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/8407d039_0007fe9e PS64, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/c432e635_3102902e PS64, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/f50575bc_80d8fe9b PS64, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/dc423b25_5af304aa PS64, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/959b7606_ae2fd7dd PS64, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/ba086e6f_c7d75ff6 PS64, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/f39f971e_f4f35f9e PS64, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/7b02b0d1_4cc7b912 PS64, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/04df0350_e4e93ba1 PS64, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/e1556ecb_1c0327ba PS64, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/458c0158_227bc441 PS64, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/a27af59a_4785bfd5 PS64, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/eed8c750_2f1bbc5d PS64, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/ed23a1f4_b05f57e7 PS64, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/f8e261c7_d6363624 PS64, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/ff2fd179_78ed23e7 PS64, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/fd3e8db8_5d56f693 PS64, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/a5dfd23a_a6f95090 PS64, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/33b0afbb_c6281196 PS64, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/51349f61_74a762fc PS64, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159940): https://review.coreboot.org/c/coreboot/+/23586/comment/8289f7b4_0d40479e PS64, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const