Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32659 )
Change subject: soc/amd/stoneyridge: Remove sb_util.c
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32659/1/src/soc/amd/stoneyridge/sb_util.c
File src/soc/amd/stoneyridge/sb_util.c:
https://review.coreboot.org/#/c/32659/1/src/soc/amd/stoneyridge/sb_util.c@a2...
PS1, Line 27:
:
:
:
:
See the commit message re. its removal.
What I'm saying is that pm_acpi_pm_cnt_blk was moved to SMI handler, but pm_acpi_pm_evt_blk is moved nowhere... Apparently it's not used, or compile would have complained... but why was it there to start with?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c4394e3cf26f4ad60a078948a84303bda693d0
Gerrit-Change-Number: 32659
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 May 2019 19:08:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment