Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37455 )
Change subject: libpayload/drivers/i8042: If configured ignore all i8042 init failures
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37455/4/payloads/libpayload/drivers...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/37455/4/payloads/libpayload/drivers...
PS4, Line 338: i8042_cmd(I8042_CMD_EN_KB);
@Mat, please check my comment in tracker. We can skip from here if EC don't want to change it. […]
I think your suggestion may have merit but I believe that we should move forward with this change and make sure we understand the full impact of your suggestion on the bug before making any further changes in this area.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37455
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1c908b11afb8098a6cbbfa8a3d4391cabacd0f
Gerrit-Change-Number: 37455
Gerrit-PatchSet: 4
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Dec 2019 23:34:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment