Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37589 )
Change subject: mb/google/hatch/variant/kohaku: Drop early gpio MEM_STRAP conf ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37589/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37589/2//COMMIT_MSG@9 PS2, Line 9: No need to configure the mem_strap in the early gpio block and again : later. This is not about configuring early and again later. The reason why the MEM_STRAP gpios were not added to early_gpio table is because the routines that make use of the MEM_STRAP gpios run before ramstage is run and those routines configure the pads before reading them. Hence as this comment suggests https://review.coreboot.org/c/coreboot/+/37589/2/src/mainboard/google/hatch/..., MEM_STAP gpios were intentially not configured in early_gpio table.
The configuration in ramstage is mostly a don't care since nothing after romstage really looks at the straps.