[coreboot-gerrit] [L] Change in coreboot[main]: acpi: Move acpigen_write_OSC_pci_domain to Xeon-SP

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Johnny Lin, Jonathan Zhang, Lance Zhao, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu, Tim Wawrzynczak.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81652?usp=email )

Change subject: acpi: Move acpigen_write_OSC_pci_domain to Xeon-SP
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: 
since the acpi code seems to be part of the acpi spec (haven't checked, but the comments in the code suggest that), i'd be in favor of keeping this code in acpi/acpigen.c. i'd however like to not have weak function in the common code if that can be easily avoided which is the case here. i see two possibilities for this: pass the uint32_t osc feature flags as function argument or just remove the weak function implementations and require the soc code calling these functions to implement the get feature functions; socs hat don't call the 3 new functions won't need to implement the get feature functions, since those won't be called so the linker won't need the get feature functions to be resolvable symbols