[coreboot-gerrit] Change in ...coreboot[master]: vboot: init display on recovery request

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32906 )

Change subject: vboot: init display on recovery request
......................................................................

Patch Set 4:

(1 comment)

Sorry for missing this.

https://review.coreboot.org/#/c/32906/4/src/security/vboot/vboot_logic.c 
File src/security/vboot/vboot_logic.c:

https://review.coreboot.org/#/c/32906/4/src/security/vboot/vboot_logic.c@371 
PS4, Line 371: 	/* Jot down some information from vboot which may be required later on
             : 	   in coreboot boot flow. */
             : 	if (ctx.flags & VB2_CONTEXT_DISPLAY_INIT)
             : 		/* Mainboard/SoC should initialize display. */
             : 		vboot_get_working_data()->flags |= VBOOT_WD_FLAG_DISPLAY_INIT;
             : 	if (ctx.flags & VB2_CONTEXT_DEVELOPER_MODE)
             : 		vboot_get_working_data()->flags |= VBOOT_WD_FLAG_DEVELOPER_MODE;
> Okay, I'll verified this tomorrow. I also guess that cause by recovery won't go to phase 2. […]

Yes, I agree with Joel, the DISPLAY_INIT flag should already work correctly but the bug is that this block isn't executed in recovery mode. It needs to be moved before the return value check.