Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40255 )
Change subject: soc/intel/apollolake: Disable XHCI LFPS power management
......................................................................
Patch Set 21: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/40255/19/src/mainboard/google/octop...
File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/40255/19/src/mainboard/google/octop...
PS19, Line 81: NULL
it's variable initialization. […]
Well, it will make scan-build complain about it. Since the code was moved to another change, marking as resolved
https://review.coreboot.org/c/coreboot/+/40255/19/src/mainboard/google/octop...
PS19, Line 85: cfg != NULL
`cfg != NULL` is the same as just `cfg`
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40255
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic603e3b919d8b443c6ede8bb5e46e2de07fcb856
Gerrit-Change-Number: 40255
Gerrit-PatchSet: 21
Gerrit-Owner: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Henry Sun
henrysun@google.com
Gerrit-Comment-Date: Fri, 10 Apr 2020 09:37:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marx Wang
marx.wang@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment