Marty E. Plummer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36346 )
Change subject: cbfs: read header offset as explicitly LE
......................................................................
Patch Set 3:
Patch Set 2: Code-Review+2
You'll probably want to add explicit conversion to LE in cbfstool as well.
Unless I'm mistaken, util/cbfstool/cbfstool.c:286 or so already does so,
calling write_le32 for this pointer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc99b0c133faa2aa15d06f998e7371d332ffa490
Gerrit-Change-Number: 36346
Gerrit-PatchSet: 3
Gerrit-Owner: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marty E. Plummer
hanetzer@startmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 02 Nov 2019 23:33:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment