Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38821 )
Change subject: cpu/x86/smm: Remove blank line in code
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38821/2/src/cpu/x86/smm/smm_module_...
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/38821/2/src/cpu/x86/smm/smm_module_...
PS2, Line 399: // account for the bios resource list
If you ask me, the blank line actually helps differentiating the blocks of code. IMHO, the lone C++ style comment that starts in lowercase is more of an eyesore. Oh, and 'bios' in lowercase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38821
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9754c6723ecd5e4895898490fc7228e1c3839d0
Gerrit-Change-Number: 38821
Gerrit-PatchSet: 2
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Feb 2020 21:51:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment