Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47258 )
Change subject: mb/google/volteer: Configure IA32_L3_MASK_x MSRs for L3 CQOS ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47258/3//COMMIT_MSG Commit Message:
PS3: Can you please stack this change on top of CB:47259
https://review.coreboot.org/c/coreboot/+/47258/3//COMMIT_MSG@9 PS3, Line 9: For Tigerlake, number of ways marked for eviction is done through : IA32_L3_MASK_1 & IA32_L3_MASK_2 MSRs. I think you will need some more details to explain why Kconfig selection is changing and what impact it has. Also, it would be good to add a note saying that eventually TGL will have to switch back to _V2 once the SF_MASK programming requirements are understood.