Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32353 )
Change subject: board/kukui: Support ADC value for NC
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32353/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32353/4//COMMIT_MSG@14
PS4, Line 14: improved
improve
https://review.coreboot.org/#/c/32353/4/src/mainboard/google/kukui/boardid.c
File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/#/c/32353/4/src/mainboard/google/kukui/boardid.c...
PS4, Line 91: assert(0);
Why is the assert still needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32353
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d00956e0e3b48ddbcaa505dd3ade24720c3b4ad
Gerrit-Change-Number: 32353
Gerrit-PatchSet: 5
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: You-Cheng Syu
youcheng@google.com
Gerrit-Comment-Date: Thu, 18 Apr 2019 10:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment