9 Jul
2021
9 Jul
'21
2:43 a.m.
Attention is currently required from: Hung-Te Lin, Martin Roth, Julius Werner, Yu-Ping Wu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56130 )
Change subject: Revert "Makefile.inc: Drop the cbfs master header from non-X86" ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56130/comment/18163b03_ad7966b9 PS1, Line 11: Breaks libpayload CBFS code when accessing : non-primary CBFS. So not having a master cbfs header in the primary CBFS breaks CBFS that never contain the header? That's odd ^^.
Patchset:
PS1: I'll have a go at fixing libpayload.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56130
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7f47406e6126f19e1fd6bc9d33c8c9d0cb9450d
Gerrit-Change-Number: 56130
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 08 Jul 2021 23:43:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment