Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/31453 )
Change subject: gma: Add more PCI IDs for Coffee/Whiskey/Amber Lake ......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 5:
GFX device id?src/soc/intel/common/block/graphics/graphics.c shall have the whole list.
Thanks. Alas, this list is far from complete. It only contains the IDs that are already used with upstream coreboot.
In the past, Intel had comprehensive lists in the Specification Updates. This stopped at some point. But I've learned in the meantime that there are "Stepping and IDs" User Guides now, e.g. [1][2]. Those have 28 IDs for KBL+CFL+AML alone, the coreboot source only 12 of them.
As these are NDA documents, I only add IDs that are publicly available, e.g. in Linux source code. Maybe you know public versions of these documents? I don't think they are kept under wraps on purpose.
[1] 567957 [2] 573255
But pci devices ID must be published anyway right? The thing is we can add the missing 16 IDs but that had not been tested which will make it a little bit tricky .....