Patch Set 5:

Patch Set 5:

GFX device id?src/soc/intel/common/block/graphics/graphics.c shall have the whole list.

Thanks. Alas, this list is far from complete. It only contains
the IDs that are already used with upstream coreboot.

In the past, Intel had comprehensive lists in the Specification
Updates. This stopped at some point. But I've learned in the
meantime that there are "Stepping and IDs" User Guides now,
e.g. [1][2]. Those have 28 IDs for KBL+CFL+AML alone, the
coreboot source only 12 of them.

As these are NDA documents, I only add IDs that are publicly
available, e.g. in Linux source code. Maybe you know public
versions of these documents? I don't think they are kept under
wraps on purpose.

[1] 567957
[2] 573255

But pci devices ID must be published anyway right? The thing is we can add the missing 16 IDs but that had not been tested which will make it a little bit tricky .....

View Change

To view, visit change 31453. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: If01883ba95246f9bfd66049772597e0317e294d2
Gerrit-Change-Number: 31453
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-CC: Lijian Zhao <lijian.zhao@intel.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 02 May 2019 20:13:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment