Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32761 )
Change subject: soc/intel/broadwell: Use the common cpu/intel/car romstage entry
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
Does somebody want to hit "Rebase"? If I do, my +2
doesn't count anymore.
https://review.coreboot.org/#/c/32761/10/src/soc/intel/broadwell/romstage/Ma...
File src/soc/intel/broadwell/romstage/Makefile.inc:
https://review.coreboot.org/#/c/32761/10/src/soc/intel/broadwell/romstage/Ma...
PS10, Line 3: ../../../..
For some reason that get's interpreted as src/soc/intel/broadwell/romstage/src/cpu/intel/car/romstag […]
Oh, $(src) is a relative path, missed that (`cpu_incs` doesn't have our
compilation class semantics, so it works there).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32761
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95645271e0d93a97f544a1cc4e9a4320738e6a20
Gerrit-Change-Number: 32761
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 15 May 2019 10:32:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment