Attention is currently required from: Jason Nien, Matt DeVillier, Chris Wang, Martin Roth, Karthik Ramasubramanian.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69565 )
Change subject: mb/google/skyrim/var/frostflow: Set DPTC Electrical Parameters
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/skyrim/variants/frostflow/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/69565/comment/f9e93088_fe8ea731
PS1, Line 8: register "slow_ppt_limit_mW" = "15000"
In IRM doc#57136, the sPPT is 25w and fPPT is 30w. it doesn't match IRM for 15w configuration. […]
Sorry, I committed an error.
And re-upload for review.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15a69df1436aba05bc19eaffd79394e5ca9bdb3a
Gerrit-Change-Number: 69565
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 14 Nov 2022 09:41:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-MessageType: comment