Jeremy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37660 )
Change subject: ifwitool: Introduce a skip BPDT parameter
......................................................................
Patch Set 2:
(2 comments)
Thanks for your review. I took both comments into account.
https://review.coreboot.org/c/coreboot/+/37660/1/util/cbfstool/ifwitool.c
File util/cbfstool/ifwitool.c:
https://review.coreboot.org/c/coreboot/+/37660/1/util/cbfstool/ifwitool.c@23
PS1, Line 23: #define max(a, b) (((a) > (b)) ? (a) : (b))
As we do have access to commonlib would you consider using commonlib/helpers. […]
Good point, I cscoped for lower case only...
Done
https://review.coreboot.org/c/coreboot/+/37660/1/util/cbfstool/ifwitool.c@19...
PS1, Line 1904: NB
What does NB stand for, number?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37660
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If32ec11fc7291d52b821bf95c1e186690d06ba11
Gerrit-Change-Number: 37660
Gerrit-PatchSet: 2
Gerrit-Owner: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Dec 2019 16:26:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment