Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31219 )
Change subject: src/drivers/intel/wifi/Kconfig: add NO_INTEL_WIFI option
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31219/1/src/drivers/intel/wifi/Kconfig
File src/drivers/intel/wifi/Kconfig:
https://review.coreboot.org/#/c/31219/1/src/drivers/intel/wifi/Kconfig@4
PS1, Line 4: default y if PCIEXP_PLUGIN_SUPPORT && !NO_INTEL_WIFI
iirc, the decision to default to `y` was because you can never
tell what the user did to his hardware.
If we'd change that, I would prefer a per-board opt-in rather
than an opt-out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31219
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia21a141e25e58f6126a6d48d83cdfb4f746f3320
Gerrit-Change-Number: 31219
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Comment-Date: Sun, 03 Feb 2019 17:25:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment