Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40612 )
Change subject: soc/intel/jasperlake: Enable end of post support in FSP
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40612/4/src/soc/intel/jasperlake/fs...
File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/40612/4/src/soc/intel/jasperlake/fs...
PS4, Line 103: Send
Possible to convert this into enums
enum {
CHIPSET_LOCKDOWN_FSP = 0, /* FSP handles locking per UPDs */
CHIPSET_LOCKDOWN_COREBOOT, /* coreboot handles locking */
};
Additionally for security reason, can we add an assert to avoid soc users to pass 0 to skip EOP?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie21dcfc84d331f036090d01ea3e3925b81eea902
Gerrit-Change-Number: 40612
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:38:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment