[coreboot-gerrit] Change in ...coreboot[master]: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31214 )

Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................

Patch Set 1:

(1 comment)

Is this just about the defaults or about something
the boards can't do? If the former, you can ignore
my inline comment.

https://review.coreboot.org/#/c/31214/1/src/mainboard/intel/coffeelake_rvp/K... 
File src/mainboard/intel/coffeelake_rvp/Kconfig:

https://review.coreboot.org/#/c/31214/1/src/mainboard/intel/coffeelake_rvp/K... 
PS1, Line 49: 	default n if BOARD_INTEL_COFFEELAKE_RVP11 || BOARD_INTEL_COFFEELAKE_RVP8
The `config CHROMEOS` is about building for cros
not if the board is compatible. If I understand
the commit message correctly these boards don't
support it, do they? If that's the case, please
don't `select MAINBOARD_HAS_CHROMEOS` for them
above and make this a dependency here.