Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33244 )
Change subject: Revert "libpayload: Reset PS/2 keyboard" ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33244/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33244/1//COMMIT_MSG@10 PS1, Line 10: the keyboard also sends the result : of the self test (passed/failed) That is what I found in the keyboard controller implementation of Chrome EC as well (i.e. it sends OK twice after the ACK). However, I could not trace the history of why it was done or any documentation to support it. I found this ancient document [1] and its abridged version [2] that indicate reset sends back ACK but does not talk about OK/FAIL response. If you run into any code comments/document that talk about the passed/failed response, I would love to add it to my references. Thanks!
[1] http://bitsavers.trailing-edge.com/pdf/ibm/pc/at/1502494_PC_AT_Technical_Ref...
[2] http://zet.aluzina.org/images/d/d4/8042.pdf