Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38278 )
Change subject: mb/google/dedede: Add GPIO stubs ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38278/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38278/5/src/mainboard/google/dedede... PS5, Line 9: #include <baseboard/gpio.h> not needed?
https://review.coreboot.org/c/coreboot/+/38278/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38278/5/src/mainboard/google/dedede... PS5, Line 9: #include <baseboard/gpio.h> not needed?
https://review.coreboot.org/c/coreboot/+/38278/5/src/mainboard/google/dedede... PS5, Line 13: #include <variant/gpio.h> not needed?