Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33142 )
Change subject: Kconfig: Create coreboot separate stage kconfigs ......................................................................
Patch Set 1:
(1 comment)
How do we envision these being used? Are we expecting platforms to default them to disabled?
https://review.coreboot.org/#/c/33142/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/33142/1/src/Kconfig@23 PS1, Line 23: default y if Because of where these are at the top of the the Kconfig tree, individual platform or chips can't update these. Remember that the first valid default is taken and the rest are ignored.
I also don't think we need a prompt for these as they generally aren't something the user would change. They'll be set by the platform and left alone.
My thoughts: 1) Move these config options to the bottom of this file so the defaults can be set elsewhere 2) Remove the prompts 3) Set default to y for all in this file 4) Set default to n in the architecture Kconfig files where that makes sense. Or add the prompt there if appropriate.